Fixed semaphore logic in uart_syslink.c #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This (should?) fix two issues: 1. Sometimes the queues and semaphores weren't initialized before the first interrupt was triggered, and the interrupt tried to push data to a null queue. This occured once on a warm restart, I'm not sure if it affects cold boots. 2. The semaphore logic seemed incorrect (eg. uartslkSendDataIsrBlocking wouldn't have blocked). I have now made this explicit using two semaphores. It might be overkill, I think there is only one task that calls these functions. But it should solve the problem. Signed-off-by: Mike Hamer <[email protected]>
|
The tests failed due to: Which is not an issue with the PR. I have compiled this for CF1 and CF2, and flight tested on CF2. |
|
I am relaunching the build, this should only be transient. |
|
This looks great! It seems the solve the occasional crash upon connections. Thanks, it is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix two issues:
Note that this only affects the CF2 (since the file isn't included for the CF1), and I have been flying successfully with the change for the last few days.
Signed-off-by: Mike Hamer [email protected]